Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PA-5943) Remove unneeded augeas versions & default to augeas 1.14.1 #840

Merged
merged 1 commit into from
Apr 26, 2024
Merged

(PA-5943) Remove unneeded augeas versions & default to augeas 1.14.1 #840

merged 1 commit into from
Apr 26, 2024
+4 −52

Conversation

AriaXLi
Copy link
Contributor

@AriaXLi AriaXLi commented Apr 25, 2024 •
edited
Loading

This commit:

  • Remove augeas versions 1.13.0, 1.8.1, 1.11.0
  • Remove patches for those removed augeas versions
  • Default to augeas 1.14.1 instead of 1.8.1
  • Update bolt-runtime to use augeas 1.4.1

@AriaXLi AriaXLi requested review from a team as code owners April 25, 2024 19:11
@AriaXLi
Copy link
Contributor Author

AriaXLi commented Apr 25, 2024

Successfully built bolt-runtime locally:

❯ bundle exec vanagon build bolt-runtime el-8-x86_64 --preserve always
...
Downloading file 'augeas-1.14.1.tar.gz' from url 'https://artifactory.delivery.puppetlabs.net/artifactory/generic/buildsources/augeas-1.14.1.tar.gz'
...

@AriaXLi
(PA-5943) Remove unneeded augeas versions & default to augeas 1.14.1
9c6456a 
This commit:
- Remove augeas versions 1.13.0, 1.8.1, 1.11.0
- Remove patches for those removed augeas versions
- Default to augeas 1.14.1 instead of 1.8.1
- Update bolt-runtime to use augeas 1.4.1
@AriaXLi AriaXLi force-pushed the PA-5943/remove_unneeded_augeas_versions branch from cfca974 to 9c6456a Compare April 25, 2024 20:52
@AriaXLi AriaXLi changed the title (PA-5943) WIP (PA-5943) Remove unneeded augeas versions & default to augeas 1.14.1 Apr 25, 2024
@AriaXLi
Copy link
Contributor Author

AriaXLi commented Apr 25, 2024 •
edited
Loading

Running my changes in platform_vanagon-generic-builder to build bolt-runtime just to double check my changes

built bolt-runtime on vanagon-generic-builder: https://jenkins-platform.delivery.puppetlabs.net/job/platform_vanagon-generic-builder_vanagon-packaging-ship-repos_generic-builder/1515/

Attempting to fetch from mirror URL "https://artifactory.delivery.puppetlabs.net/artifactory/generic/buildsources/augeas-1.14.1.tar.gz"
Executing 'git ls-remote --heads https://artifactory.delivery.puppetlabs.net/artifactory/generic/buildsources/augeas-1.14.1.tar.gz > /dev/null 2>&1' locally
Downloading file 'augeas-1.14.1.tar.gz' from url 'https://artifactory.delivery.puppetlabs.net/artifactory/generic/buildsources/augeas-1.14.1.tar.gz'
Verifying file: augeas-1.14.1.tar.gz against sum: 'ac31216268b4b64809afd3a25f2515e5'

@cthorn42 cthorn42 merged commit b39ac7f into puppetlabs:master Apr 26, 2024
3 checks passed
@joshcooper joshcooper added the maintenance Maintenance chores are typically excluded from changelogs label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cthorn42 cthorn42 cthorn42 approved these changes

Assignees
No one assigned
Labels
maintenance Maintenance chores are typically excluded from changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AriaXLi @cthorn42 @joshcooper